[PATCH] D94771: [Object, llvm-readelf] - Move the API for retrieving symbol versions to ELF.h

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 05:48:35 PST 2021


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
grimar requested review of this revision.
Herald added a project: LLVM.

`ELFDumper.cpp` implements the functionality that allows to get symbol versions.
It is used for dumping versioned symbols.

We have the https://bugs.llvm.org/show_bug.cgi?id=48670 bug which
suggests that `llvm-nm` also should print version names for symbols.

To achieve it, we can move out and reuse the code from `ELFDumper.cpp`.
This is what this patch do: it moves the related functionality to `ELFFile<ELFT>`.

I have a prototype of the patch for `llvm-nm` which uses this change and fixes PR48670.
I am planning to post it early on the next week, when it be ready for review.


https://reviews.llvm.org/D94771

Files:
  llvm/include/llvm/Object/ELF.h
  llvm/test/tools/llvm-readobj/ELF/verdef-invalid.test
  llvm/test/tools/llvm-readobj/ELF/verneed-invalid.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94771.316919.patch
Type: text/x-patch
Size: 32772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210115/1141677d/attachment.bin>


More information about the llvm-commits mailing list