[PATCH] D92215: [WebAssembly] MC layer writes table symbols to object files

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:523
+    // The linker won't be able to make the connection between TABLE_INDEX
+    // relocs and the specific table symbol, so explicitly prevent GC from
+    // eliding the symbol.  In the future we may want to define a new kind of
----------------
I thought the plan was to include this table symbol in a new TABLE_NUMBER reloc to go along with the TABLE_INDEX reloc?  Then each call_indirect could have up to two different relocations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92215/new/

https://reviews.llvm.org/D92215