[PATCH] D92934: [ARM][MachineOutliner] Add stack fixup feature.

[Sam Parker via Phabricator via llvm-commits]

samparker added a comment.

Sorry for the big delay Yvan, I haven't really been working on LLVM recently.



================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5899
+
+  switch (AddrMode) {
+  case ARMII::AddrMode3:
----------------
How about extracting this out into ARMBaseInstrInfo? There seems to be a fair number of places in the backend where getting the NumBits and Scale comes up.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:6375
+  // Walk over the basic block and fix up all the stack accesses.
+  fixupPostOutline(MBB);
 }
----------------
Does this mean that we can call fixupPostOutline twice on MBB? I'm confused why we're checking for saving LR here, when it looks like we'd know for sure around line 6351.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92934/new/

https://reviews.llvm.org/D92934