[PATCH] D93900: [llvm-readef/obj] - Change the design structure of ELF dumper. NFCI.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2644
 
-namespace {
-
----------------
danilaml wrote:
> Why was this removed?
> I think it broke compilation on GCC older than 7.0+
> 
> See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480
> 
> ```
>  error: specialization of ‘template<class ELFT> void {anonymous}::ELFDumper<ELFT>::printUnwindInfo()’ in different namespace [-fpermissive]
>  template <> void ELFDumper<ELF32LE>::printUnwindInfo() {
>                                                       ^
> ../tools/llvm-readobj/ELFDumper.cpp:241:8: error:   from definition of ‘template<class ELFT> void {anonymous}::ELFDumper<ELFT>::printUnwindInfo()’ [-fpermissive]
>    void printUnwindInfo() override;
> ```
> 
> I wonder why wasn't it caught y any of the buildbots.
Hmm. I wasn't aware this is usefull. That's why. I'll restore shortly with the comment saying that GCC <7 wants it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93900/new/

https://reviews.llvm.org/D93900