[PATCH] D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats

Kevin Peizner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 16:45:21 PST 2021


kevinpeizner added a comment.

In D94557#2498984 <https://reviews.llvm.org/D94557#2498984>, @compnerd wrote:

> I agree with Renato, this seems incorrect.  In the EABI mode, we should prefer the EABI symbols.

Maybe I'm miss understanding, but this change ensures EABI symbols are still used when EABI is targeted. The `fp16.ll` regression test verifies this is the case, no?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94557/new/

https://reviews.llvm.org/D94557



More information about the llvm-commits mailing list