[PATCH] D91583: [LTO] Prevent devirtualization for symbols exported to dynamic linker

Thu Jan 14 14:18:35 PST 2021

tejohnson added inline comments.

================
Comment at: lld/test/ELF/lto/devirt_vcall_vis_export_dynamic.ll:2
 ; REQUIRES: x86
-; Test that --lto-whole-program-visibility enables devirtualization.
+; Test that --export-dynamic[-symbol] and --dynamic-list prevents devirtualization.

----------------
tejohnson wrote:
> MaskRay wrote:
> > Nit: in LLD tests we use `;; ` to differentiate regular comments from `CHECK` `RUN` markers.
> Can I do this in a follow on NFC commit? Otherwise it will make the diffs really noisy in this test.
I went ahead and fixed this in the existing tests in 5b42fd8dd4e7e29125a09a41a33af7c9cb57d144. I have updated this with a rebased version that fixes the comments in the new tests as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91583/new/

https://reviews.llvm.org/D91583