[PATCH] D88438: BreakCriticalEdges: do not split the critical edge from a CallBr indirect successor

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 13:43:18 PST 2021


nickdesaulniers added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/callbr-critical-edge-splitting.ll:1
+; RUN: opt < %s -o /dev/null -loop-reduce
+
----------------
MaskRay wrote:
> Just use the new PM way: `-passes='loop(loop-reduce)'`
If I do that for both tests:
1. this one passes before this patch has been applied. (bad)(lol, wut)
2. the other test still fails. (good)

Is there something funny with NPM that I need to specify additional passes in addition to `loop(loop-reduce)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88438/new/

https://reviews.llvm.org/D88438



More information about the llvm-commits mailing list