[PATCH] D94690: [Orc] Allow errors via output parameter in LLJITBuilder's CreateObjectLinkingLayer

[Lang Hames via Phabricator via llvm-commits]

lhames added inline comments.


================
Comment at: llvm/examples/OrcV2Examples/LLJITWithCustomObjectLinkingLayer/LLJITWithCustomObjectLinkingLayer.cpp:48
           .setObjectLinkingLayerCreator(
-              [&](ExecutionSession &ES, const Triple &TT) {
+              [&](ExecutionSession &ES, const Triple &TT, Error &Err) {
                 return std::make_unique<ObjectLinkingLayer>(
----------------
Rather than pass an Error by reference here, could you change ObjectLinkingLayerCreator's signature to return an Expected<std::unique_ptr<ObjectLayer>> ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94690/new/

https://reviews.llvm.org/D94690