[PATCH] D94427: [NFC][InstructionCost] Use InstructionCost in lib/Transforms/IPO/IROutliner.cpp
Andrew Litteken via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 14 11:09:04 PST 2021
AndrewLitteken added a comment.
This looks fine to me, just one small nit in getBenefit for consistency with the rest of the patch.
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:247
+InstructionCost OutlinableRegion::getBenefit(TargetTransformInfo &TTI) {
InstructionCost Benefit(0);
----------------
I know this isn't part of the patch, but should probably be fixed to match up with the rest of the changes..
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94427/new/
https://reviews.llvm.org/D94427
More information about the llvm-commits
mailing list