[PATCH] D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 10:34:52 PST 2021


nickdesaulniers added a comment.

Patch fixes the reported bug; added test cases produces a crash before patch is applied.  LGTM with minor nit.



================
Comment at: llvm/lib/Target/Mips/MipsDelaySlotFiller.cpp:572
+    ToErase->getMF()->moveCallSiteInfo(ToErase, cast<MachineInstr>(&*Branch));
   std::next(Branch)->eraseFromParent();
   return Branch;
----------------
Do you want to use

    ToErase->eraseFromParent();

here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94685/new/

https://reviews.llvm.org/D94685



More information about the llvm-commits mailing list