[PATCH] D94285: [llvm] Protect signpost map with a mutex

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 10:01:20 PST 2021


dsanders added a comment.

A sys::SmartMutex equivalent of this would LGTM. Let me know if there's a reason we should stick to std::mutex



================
Comment at: llvm/lib/Support/Signposts.cpp:42
   DenseMap<const void *, os_signpost_id_t> Signposts;
+  std::mutex Mutex;
 
----------------
Timer.cpp uses `sys::SmartMutex` so that single threaded builds don't have to do the mutex. We should do the same here unless there's a good reason to use std::mutex


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94285/new/

https://reviews.llvm.org/D94285



More information about the llvm-commits mailing list