[PATCH] D94693: Improve KnownBits analyses for SMIN/SMAX DAG nodes.
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 14 09:55:54 PST 2021
foad added inline comments.
================
Comment at: llvm/test/CodeGen/X86/avx512-trunc.ll:1018
+; SKX-NEXT: vpcmpeqd %ymm0, %ymm0, %ymm0
; SKX-NEXT: vpmovwb %ymm0, (%rdi)
; SKX-NEXT: vzeroupper
----------------
aymanmus wrote:
> RKSimon wrote:
> > Same problem as D87145 - this isn't testing what its supposed to be testing.....
> I agree, the test doesn't make sense.
It does seem a little unfair to let that block these patches though. I don't know what the X86 maintainers intended to test!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94693/new/
https://reviews.llvm.org/D94693
More information about the llvm-commits
mailing list