[PATCH] D94546: [RISCV] Optimize select_cc after fp compare expansion

[Sam Elliott via Phabricator via llvm-commits]

lenary added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1817
     break;
+  case RISCVISD::SELECT_CC: {
+    // Transform
----------------
We should absolutely document that this expects the condition to be an `xleni` with values corresponding to `getBooleanContents`. This should go where the opcode is defined in RISCVISelLowering.h though.

Given this seems to be the case, I think this optimization is correct (or as correct as my patch).




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94546/new/

https://reviews.llvm.org/D94546