[PATCH] D94422: [flang][driver] Unify f18_version.h.in and Version.inc.in

Thu Jan 14 08:54:03 PST 2021

awarzynski added inline comments.

================
Comment at: flang/tools/f18/f18.cpp:392-393
   llvm::errs() << "\nf18 compiler (under development), version "
-               << __FLANG_MAJOR__ << "." << __FLANG_MINOR__ << "."
-               << __FLANG_PATCHLEVEL__ << "\n";
+               << FLANG_VERSION_MAJOR << "." << FLANG_VERSION_MINOR << "."
+               << FLANG_VERSION_PATCHLEVEL << "\n";
   return exitStatus;
----------------
sameeranjoshi wrote:
> `Nit`: Why not `FLANG_VERSION`
> It's already appended with `.` at https://github.com/llvm/llvm-project/blob/e8622d27c0e3020177ff47ad57dd1e5371feb9cf/flang/CMakeLists.txt#L286
I missed that, thanks for pointing out! Fixed here: https://reviews.llvm.org/rG0afdbb4d2dead42df14361ca9f5613d56667481c

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94422/new/

https://reviews.llvm.org/D94422