[PATCH] D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 14 08:19:16 PST 2021
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:1887-1893
+ // Usually InputReg is a function live in, so there will not be one.
+ for (MachineBasicBlock::iterator I = MBB.begin(), E = MI.getIterator();
+ I != E && !FirstMI; ++I) {
+ isInputRead = isInputRead || I->readsRegister(InputReg);
+ if (I->definesRegister(InputReg))
+ FirstMI = &*(std::next(I));
+ }
----------------
We shouldn't need to do ad-hoc use/def searches. Can you do this pre-RA, post-SSA like SILowerControlFlow?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94645/new/
https://reviews.llvm.org/D94645
More information about the llvm-commits
mailing list