[PATCH] D94691: [ARM] Don't run the block placement pass at O0

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 07:58:09 PST 2021


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Yep, don't think it is useful or necessary to run this at O0.
LGTM.



================
Comment at: llvm/lib/Target/ARM/ARMTargetMachine.cpp:556
 
-  addPass(createARMBlockPlacementPass());
+  if (getOptLevel() != CodeGenOpt::None)
+    addPass(createARMBlockPlacementPass());
----------------
Nit: perhaps merge this with if below, and say something like: 

  // Don't optimize barriers and block placement at -O0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94691/new/

https://reviews.llvm.org/D94691



More information about the llvm-commits mailing list