[PATCH] D94659: [yaml2obj/obj2yaml] - Refine handling of SHT_GNU_verdef sections.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 14 04:21:57 PST 2021
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with nit.
================
Comment at: llvm/test/tools/yaml2obj/ELF/verdef-section.yaml:82-83
- VERSION_1
- - Version: 1
- Flags: 3
- VersionNdx: 3
- Hash: 108387922
+## Case 4: an entry that has version predecessors. Also, it sets
+## all known flags as well as few unknown.
+ - Flags: 0xffff
----------------
How about: "an entry that has version predecessors and a selection of flags, (all known, some unknown)."
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94659/new/
https://reviews.llvm.org/D94659
More information about the llvm-commits
mailing list