[PATCH] D94659: [yaml2obj/obj2yaml] - Refine handling of SHT_GNU_verdef sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/ELF/verdef-section.yaml:70
+## Document that we are not able to dump a version definition which
+## has the version revision (vd_version) that is not equal to 1.
+
----------------



================
Comment at: llvm/test/tools/yaml2obj/ELF/verdef-section.yaml:62
     Entries:
-      - Version:         1
-        Flags:           1
-        VersionNdx:      1
-        Hash:            170240160
+## Case 1: an entry that has no Version, Flags, VersionNdx nor Hash fields set.
+##         Used to check values that are written by default. Also shows
----------------



================
Comment at: llvm/test/tools/yaml2obj/ELF/verdef-section.yaml:82
           - VERSION_1
-      - Version:         1
-        Flags:           3
-        VersionNdx:      3
-        Hash:            108387922
+## Case 4: an entry that has version predecessors and all known flags set.
+      - Flags:      7
----------------
What about unknown flags?


================
Comment at: llvm/test/tools/yaml2obj/ELF/verdef-section.yaml:94
 
+## Check we are able to emit a version definition which has the version revision
+## (vd_version) field value that is not equal to 1.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94659/new/

https://reviews.llvm.org/D94659