[PATCH] D94658: Remove redundant move call in return statements

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 14 02:18:22 PST 2021


RKSimon added a comment.

I'm not certain but I thought some of these moves had to be kept to appease old versions of gcc - but I can't remember any details.



================
Comment at: llvm/include/llvm/Bitstream/BitstreamReader.h:429
         if (Error Err = ReadAbbrevRecord())
-          return std::move(Err);
+          return Err;
         continue;
----------------
Any idea what clang-tidy is warning about here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94658/new/

https://reviews.llvm.org/D94658



More information about the llvm-commits mailing list