[PATCH] D94075: [lld][WebAssembly] Add support for handling table symbols

[Andy Wingo via Phabricator via llvm-commits]

wingo marked 5 inline comments as done.
wingo added inline comments.


================
Comment at: lld/wasm/InputTable.h:46
+
+  bool live = false;
+
----------------
sbc100 wrote:
> I don't if its worth have a common base class for `InputGlobal`, `InputEvent`, `InputTable` and `InputChunk`.  At least they all seem to share the `file` and `live` members.    Perhaps we can do that a followup?
Sure, I can take a look in a followup.


================
Comment at: lld/wasm/SyntheticSections.h:156
+    // unless it is imported, we need a table section.  FIXME: Treat
+    // __indirect_function_table as a normal symbol, and only residualize a
+    // table section as needed.
----------------
sbc100 wrote:
> residualize?   I've not heard that expression before.    Is it like realize?  Or reify?
I guess it's a term more from middle-ends; like a pass that does function inlining is a source-to-source transformation, and you call the output program the residual program; you residualize code to the output.  Maybe it's more used in the FP world; see e.g. usage in Waddell and Dybvig's "Fast and effective procedure inlining".  But that paper is 20 years old and maybe it's not a good term in this context.  I'll reword.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94075/new/

https://reviews.llvm.org/D94075