[PATCH] D94560: [ELF] report section sizes when output file too large

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

FWIW, I think we could support this, but I'd implement it in a much more trivial way.
E.g. I think it can be just a 2 lines loop which would iterate over all output sections and print their names ans sizes.
No need to sort them or to calculate fields width.

Something like:

  if (fileSize != size_t(fileSize) || maxSize < fileSize) {
    std::string msg = "output file too large: " << Twine(fileSize) << " bytes\n"
      << "Largest sections:\n";
    for (OutputSection *s : outputSections)
       msg += ...;
    error(s.str());
    return;
  }

I don'f feel strong about that suggestion though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94560/new/

https://reviews.llvm.org/D94560