[PATCH] D94649: [StringExtras] Rename SubsequentDelim to ListSeparator

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 21:01:39 PST 2021


MaskRay accepted this revision.
MaskRay added a comment.

Thanks. The new name looks better! I mentioned the patch on discord. Hope one day or two is sufficient for interested folks to weigh in.



================
Comment at: llvm/unittests/ADT/StringExtrasTest.cpp:224
+  S = LS;
   EXPECT_EQ(S, ", ");
 
----------------
Not sure whether it should be committed separately:
using `LS` the third time is useful but untested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94649/new/

https://reviews.llvm.org/D94649



More information about the llvm-commits mailing list