[PATCH] D93779: ADT: Fix reference invalidation in SmallVector::push_back and single-element insert

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D93779#2497200 <https://reviews.llvm.org/D93779#2497200>, @rupprecht wrote:

> This patch seems to have found a bug: in AArch64InstrInfo.cpp, there is a `-Wsometimes-uninitialized` warning that now triggers, and adding an assertion to make sure the value is eventually set causes a few tests to fail. The usage is `DelInstrs.push_back(MUL)`, which I guess is how it ties in to this patch.
>
> More details in 752fafda3dbf1f4885c64408a13ddb67c91ccb13 <https://reviews.llvm.org/rG752fafda3dbf1f4885c64408a13ddb67c91ccb13>, which gets things back to building, but doesn't do anything about the bug.

Oh weird, I saw that too, but (wrongly) assumed it was unrelated to my change. Thanks for digging into it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93779/new/

https://reviews.llvm.org/D93779