[PATCH] D91460: [AsmParser] make .ascii support spaces as separators

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 15:04:44 PST 2021


jcai19 added a comment.

In D91460#2496849 <https://reviews.llvm.org/D91460#2496849>, @jrtc27 wrote:

> Which GDB tests? How are they broken? I'm extremely surprised by the given this patch implements what binutils has done for a very long time (only `.asciz`/`.string` have changed behaviour in binutils, and those are not modified by this patch here so should not have regressions).

The reason is unclear yet and may as well not be caused by this change as @maskray pointed out. Will reland or update the patch once we know the reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91460/new/

https://reviews.llvm.org/D91460



More information about the llvm-commits mailing list