[PATCH] D93749: [llvm-dwp] Add a command line option to set the target triple

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 13:02:08 PST 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Code change looks good - test might be able to be tweaked a bit before committing.



================
Comment at: llvm/test/tools/llvm-dwp/WebAssembly/simple.test:1
+RUN: llvm-dwp %p/../Inputs/wasm.dwo -o %t
+RUN: llvm-dwarfdump %t | FileCheck %s
----------------
Could the wasm.dwo file be written in assembly (that's more the style used these days, compared to when I wrote the original dwp tests) and assembled with llvm-mc? (this .test file could be the assembly .s file instead - self-describing/standalone in one file rather than an opaque binary beside this .test file that doesn't describe its inputs)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93749/new/

https://reviews.llvm.org/D93749



More information about the llvm-commits mailing list