[PATCH] D94585: [IndirectFunctions] Skip propagating attributes to address taken functions
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 13 10:37:31 PST 2021
rampitec added a comment.
With this patch you would set features on an address-taken function and ignore whole call stack below it. I.e. its own callees will not be processed. I think you need to continue traversal, just skip actual setting of attributes on such a function. Setting these attributes on a functions it may call in turn shall be fine.
================
Comment at: llvm/test/CodeGen/AMDGPU/propagate-attributes-direct-indirect.ll:58
+ store float* %result1, float** %result.addr.ascast, align 8
+ %1 = bitcast float (i32)* addrspace(5)* %fn to i8 addrspace(5)*
+ %2 = load i32, i32* %type.addr.ascast, align 4
----------------
There should be no numbered variables in tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94585/new/
https://reviews.llvm.org/D94585
More information about the llvm-commits
mailing list