[PATCH] D93639: [AArch64][SVE]Add cost model for vector reduce for scalable vector

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1191
+  if (isa<ScalableVectorType>(ValTy))
+    return getArithmeticReductionCostScalableVectorType(
+        Opcode, ValTy, IsPairwiseForm, CostKind);
----------------
sdesmalen wrote:
> nit: `s/getArithmeticReductionCostScalableVectorType/getArithmeticReductionCostSVE`
@CarolineConcatto pointed out to me that earlier on in this patch @ctetreau suggested the opposite.

My argument for having 'SVE' in the name over 'ScalableVectorType' is that the reduction cost is different when SVE is available, regardless of whether the type passed is a scalable or fixed-width vector. For fixed-width vectors, the compiler may still choose to use one of the SVE reduction instructions if available. The code in that function is not specific to scalable vectors either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93639/new/

https://reviews.llvm.org/D93639