[PATCH] D91583: [LTO] Prevent devirtualization for symbols exported to dynamic linker

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a subscriber: rnk.
MaskRay added inline comments.


================
Comment at: llvm/include/llvm/LTO/LTO.h:466
+  /// by a shared library not visible to the linker.
+  unsigned VisibleToDynamicLinker : 1;
+
----------------
tejohnson wrote:
> MaskRay wrote:
> > How about VisibleToOtherModules?
> > 
> > The name VisibleToDynamicLinker is too tied to the ELF binary format.
> VisibleToOtherModules sounds to me like it means LLVM Modules that are being linked together statically. I wanted to note that these are symbols that may have dynamic references not seen by the static link. Is there anything like --export-dynamic for other binary formats? If not, then it is ELF specific anyway.
@rnk for thoughts on COFF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91583/new/

https://reviews.llvm.org/D91583