[PATCH] D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost
Caroline via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 13 09:28:34 PST 2021
CarolineConcatto marked an inline comment as done.
CarolineConcatto added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:525
+ TTI.getShuffleCost(TargetTransformInfo::SK_PermuteSingleSrc, SrcTy);
+ assert(SrcCost.isValid() && "Invalid source cost");
+ if (DestCost > SrcCost || (!DestCost.isValid() && !SrcCost.isValid()))
----------------
sdesmalen wrote:
> Does this assert need to be removed still?
Yes, sorry missed that!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94069/new/
https://reviews.llvm.org/D94069
More information about the llvm-commits
mailing list