[PATCH] D94458: [PowerPC] Only use some extend mne if assembler is modern enough

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 09:14:33 PST 2021


jsji added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPC.td:60
                                         "Enable 64-bit instructions">;
+def FeatureModernAs     : SubtargetFeature<"modern-as","HasModernAs", "true",
+                                        "Has new Assembler" >;
----------------
sfertile wrote:
> Minor nit: I think name, option, description string, etc should explicitly reflect its the AIX assembler.
I updated the description and comments to mention AIX, but not the naming of feature. 
As I think we should leave this as a general feature that can be used in the future for similar workaround, not necessary AIX only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94458/new/

https://reviews.llvm.org/D94458



More information about the llvm-commits mailing list