[PATCH] D94458: [PowerPC] Only use some extend mne if assembler is modern enough

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

Thanks Jinsong, left a couple really minor comments. Will rebase the xxspltd fix on this patch now.



================
Comment at: llvm/lib/Target/PowerPC/PPC.td:60
                                         "Enable 64-bit instructions">;
+def FeatureModernAs     : SubtargetFeature<"modern-as","HasModernAs", "true",
+                                        "Has new Assembler" >;
----------------
Minor nit: I think name, option, description string, etc should explicitly reflect its the AIX assembler.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:1122
 def IsNotISA3_1 : Predicate<"!Subtarget->isISA3_1()">;
+def ModernAs: Predicate<"Subtarget->HasModernAs">, AssemblerPredicate<(all_of FeatureModernAs)>;
 
----------------
ditto in adding AIX to the name.


================
Comment at: llvm/test/MC/PowerPC/modern-as.s:2
+# RUN: llvm-mc -triple powerpc64-unknown-unknown -mattr=+modern-as --show-encoding %s | FileCheck -check-prefix=CHECK-BE %s
+# RUN: llvm-mc -triple powerpc64le-unknown-unknown -mattr=+modern-as --show-encoding %s | FileCheck -check-prefix=CHECK-LE %s
+
----------------
We should have a run step that checks for the error when '-mattr=-modern-as`.


================
Comment at: llvm/test/MC/PowerPC/ppc64-encoding-ext.s:3422
             mfxer 2
-# CHECK-BE: mtudscr 2                       # encoding: [0x7c,0x43,0x03,0xa6]
-# CHECK-LE: mtudscr 2                       # encoding: [0xa6,0x03,0x43,0x7c]
----------------
We can leave this test alone now that the mnemonic is accepted by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94458/new/

https://reviews.llvm.org/D94458