[PATCH] D92385: [ARM] Add a pass that re-arranges blocks when there is a backwards WLS branch

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 08:25:58 PST 2021


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:217
+  // Fix fall-through to the moved BB from the one that used to be before it.
+  if (BBPrevious && BBPrevious->isSuccessor(BB))
+    FixFallthrough(BBPrevious, BB);
----------------
SjoerdMeijer wrote:
> Nit: we can remove `BBPrevious` from this check because we have asserted this is set?
Ah yes, well spotted :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92385/new/

https://reviews.llvm.org/D92385



More information about the llvm-commits mailing list