[PATCH] D94592: [NFC][AsmPrinter] Windows warning: Use explicit cast

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 13 04:58:24 PST 2021


dstuttard created this revision.
Herald added a subscriber: hiraditya.
dstuttard requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

static_cast for uint64_t to unsigned gives a MS VC build warning
for Windows:

warning C4309: 'static_cast': truncation of constant value

Use an explicit cast instead.

Change-Id: I692d335b4913070686a102780c1fb05b893a2f69


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94592

Files:
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp


Index: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
===================================================================
--- llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -846,7 +846,7 @@
     CommentOS << *Size << "-byte Reload\n";
   } else if ((Size = MI.getFoldedRestoreSize(TII))) {
     if (*Size) {
-      if (*Size == static_cast<unsigned>(MemoryLocation::UnknownSize))
+      if (*Size == (unsigned)MemoryLocation::UnknownSize)
         CommentOS << "Unknown-size Folded Reload\n";
       else
         CommentOS << *Size << "-byte Folded Reload\n";
@@ -855,7 +855,7 @@
     CommentOS << *Size << "-byte Spill\n";
   } else if ((Size = MI.getFoldedSpillSize(TII))) {
     if (*Size) {
-      if (*Size == static_cast<unsigned>(MemoryLocation::UnknownSize))
+      if (*Size == (unsigned)MemoryLocation::UnknownSize)
         CommentOS << "Unknown-size Folded Spill\n";
       else
         CommentOS << *Size << "-byte Folded Spill\n";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94592.316369.patch
Type: text/x-patch
Size: 989 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210113/1014a113/attachment.bin>


More information about the llvm-commits mailing list