[PATCH] D94143: [AArch64] Add support for the GNU ILP32 ABI

[Joel Jones via Phabricator via llvm-commits]

joelkevinjones added a comment.

LGTM. I think someone else has to approve it.



================
Comment at: llvm/lib/Support/Triple.cpp:244
+  case GNUILP32:
+    return "gnu_ilp32";
   case Itanium: return "itanium";
----------------
(nit) I'd ignore the previous lint warning and combine lines here.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:6952
 
   // void *__stack at offset 0
+  unsigned Offset = 0;
----------------
joelkevinjones wrote:
> For all the following comments of the form:
> `// ... at offset n`
> perhaps change it to:
> `// ... at offset m * pointer size`
> so, for example, the next comment would be
> `// void *__gr_top at offset 1 * pointer size`
Nice. I like the separate accounting better than what I suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94143/new/

https://reviews.llvm.org/D94143