[PATCH] D94542: [X86] Default to -x86-pad-for-align=false to drop assembler difference with or w/o -g

[Kan Shengchen via Phabricator via llvm-commits]

skan added a comment.

In D94542#2494838 <https://reviews.llvm.org/D94542#2494838>, @MaskRay wrote:

> In D94542#2494774 <https://reviews.llvm.org/D94542#2494774>, @reames wrote:
>
>> Both the align and branch handling are "optimizations".  I object to one being enabled and the other disabled.  If you want them both on by default, fine.  If you want them both off by default, fine.  Having one off and one on is confusing.
>
> I can disable the other one, too. Due to `if (!X86PadForAlign && !X86PadForBranchAlign)`, disabling one suffices.

It looks good to me either to turn off both options by default or just turn off `x86-pad-for-align`, since `x86-pad-for-branch-align` doesn't work 
indeed if `x86-align-branch-boundary` or  `x86-align-branch` is disabled.  If you prefer to turn off both, remember to set  `x86-pad-for-branch-align` to true when both `x86-align-branch-boundary` and `x86-align-branch` have valid non-zero value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94542/new/

https://reviews.llvm.org/D94542