[PATCH] D94228: [flang][driver] Support fixed form detection
Tim Keith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 12 17:16:22 PST 2021
tskeith added inline comments.
================
Comment at: flang/lib/Frontend/FrontendAction.cpp:60
+ pathSuffix == "ff" || pathSuffix == "for" || pathSuffix == "FOR" ||
+ pathSuffix == "fpp" || pathSuffix == "FPP";
+ }
----------------
This set of fixed form suffixes is duplicated in `FrontendOptions.cpp`. I think it would be better two have two predicates, say `IsFixedFormSuffix` and `IsFreeFormSuffix`, so that the former can be used in both places.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94228/new/
https://reviews.llvm.org/D94228
More information about the llvm-commits
mailing list