[PATCH] D94542: [X86] Default to -x86-pad-for-align=false to drop assembler difference with or w/o -g

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 16:55:13 PST 2021


reames added a comment.

Both the align and branch handling are "optimizations".  I object to one being enabled and the other disabled.  If you want them both on by default, fine.  If you want them both off by default, fine.  Having one off and one on is confusing.

I also ask that a bit more background be given to justify this change.  I found the bug (https://bugs.llvm.org/show_bug.cgi?id=42138#c13), but that gives no information about the cause of the assembly difference.  Has anyone examined the cause of the labels being emitted in debug mode to see if they're necessary/useful?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94542/new/

https://reviews.llvm.org/D94542



More information about the llvm-commits mailing list