[PATCH] D94470: [LSR] Don't break a critical edge if parent ends with "callbr"

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 15:57:50 PST 2021


void added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/callbr-critical-edge-splitting.ll:23
+
+do.body.i.i.do.body.i.i_crit_edge:                ; preds = %do.body.i.i.do.body.i.i_crit_edge, %cond.true.i
+  %pgocount711 = phi i64 [ %0, %do.body.i.i.do.body.i.i_crit_edge ], [ 0, %cond.true.i ]
----------------
MaskRay wrote:
> Perhaps simplify the BB names. For example `_crit_edge` can be dropped as it is the name introduced by a previous critical edge breaking step. 
No. Please stop. I'm not going to rename BB names. That's just busy work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94470/new/

https://reviews.llvm.org/D94470



More information about the llvm-commits mailing list