[PATCH] D91583: [LTO] Prevent devirtualization for symbols exported to dynamic linker

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked 3 inline comments as done.
tejohnson added inline comments.


================
Comment at: lld/test/ELF/lto/devirt_vcall_vis_export_dynamic.ll:43
+; RUN:   -mllvm -pass-remarks=. \
+; RUN: 	 --export-dynamic 2>&1 | FileCheck %s --implicit-check-not single-impl --allow-empty
 ; RUN: llvm-dis %t.o.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-NODEVIRT-IR
----------------
MaskRay wrote:
> `%s` -> `/dev/null`
Fixed here and elsewhere - but not sure why it matters?


================
Comment at: lld/test/ELF/lto/devirt_vcall_vis_public.ll:8
 ; RUN: ld.lld %t2.o -o %t3 -save-temps --lto-whole-program-visibility \
-; RUN: 	 -mllvm -pass-remarks=. --export-dynamic 2>&1 | FileCheck %s --check-prefix=REMARK
+; RUN: 	 -mllvm -pass-remarks=. \
+; RUN:	 2>&1 | FileCheck %s --check-prefix=REMARK
----------------
MaskRay wrote:
> `s/\t/ /`
Done here and elsewhere


================
Comment at: lld/test/ELF/lto/devirt_vcall_vis_public.ll:9
+; RUN: 	 -mllvm -pass-remarks=. \
+; RUN:	 2>&1 | FileCheck %s --check-prefix=REMARK
 ; RUN: llvm-dis %t2.o.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR
----------------
MaskRay wrote:
> `s/\t/ /`
> 
> The two lines can be joined.
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91583/new/

https://reviews.llvm.org/D91583