[PATCH] D94350: [GlobalISel] Combine (a[0]) | (a[1] << k1) | ...| (a[m] << kn) into a wide load

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 15:28:41 PST 2021


paquette updated this revision to Diff 316256.
paquette added a comment.

Fix a bug in `isPredecessor` exposed by this patch and add a testcase for it. It wasn't able to handle the case where `DefMI` is the first instruction in the block.

I don't think it can be exposed by `findPostIndexCandidate`, so I guess I'll just fix it here where it's testable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94350/new/

https://reviews.llvm.org/D94350

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/prelegalizer-combiner-load-or-pattern.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94350.316256.patch
Type: text/x-patch
Size: 80410 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210112/aa0a2a74/attachment-0001.bin>


More information about the llvm-commits mailing list