[PATCH] D94143: [AArch64] Add support for the GNU ILP32 ABI

[Amanieu d'Antras via Phabricator via llvm-commits]

Amanieu marked 2 inline comments as done.
Amanieu added a comment.

In D94143#2493974 <https://reviews.llvm.org/D94143#2493974>, @joelkevinjones wrote:

> In D16213 <https://reviews.llvm.org/D16213> I introduced the `MCTargetOptions` argument to the `MCAsmBackend` constructor, as well as in constructor wrapper functions. This change touched multiple (every, probably) backend. Given the extension to embed the ABI in the Triple, can the `MCTargetOptions` argument be removed? That shouldn't be in this commit, I think.

That sounds reasonable. After this is accepted I will prepare another diff to revert D16213 <https://reviews.llvm.org/D16213>.

> I have't checked the new test cases for completeness. I also haven't checked whether there are existing test cases not in this commit that might usefully have "`-target-abi=ilp32`" changed to "`-triple aarch64-none-linux-gnu_ilp32`"

I've converted every existing test case using `-target-abi=ilp32` to use the new target triple.



================
Comment at: llvm/test/CodeGen/AArch64/ilp32-tlsdesc.ll:22
+; CHECK-RELOC: R_AARCH64_P32_TLSDESC_CALL
+}
----------------
joelkevinjones wrote:
> Should the `CHECK-RELOC` lines contain more complete checks like `arm32-elf-relocs.s`, for example, does? That is symbol name and offset.
I mostly copied this test from arm64-tls-dynamic.ll which also only checks the relocation name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94143/new/

https://reviews.llvm.org/D94143