[PATCH] D94486: [LTO] Expose opt() in LTOBackend (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 12:09:28 PST 2021


fhahn added inline comments.


================
Comment at: llvm/lib/LTO/LTOBackend.cpp:486
 
+bool lto::opt(const Config &Conf, TargetMachine *TM, unsigned Task, Module &Mod,
+              bool IsThinLTO, ModuleSummaryIndex *ExportSummary,
----------------
steven_wu wrote:
> Any reason why the function need to be moved instead of just renamed? I will reduce the diff if possible.
Unfortunately it is originally defined in a anonymous namespace, so I think it has to be moved out of that to be defined in `lto::`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94486/new/

https://reviews.llvm.org/D94486



More information about the llvm-commits mailing list