[PATCH] D94437: [AArch64][GlobalISel] Add support for FCONSTANT of FP128 type

Tue Jan 12 11:10:50 PST 2021

arsenm added inline comments.

================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:2318-2319
       // can be sure tablegen works correctly and isn't rescued by this code.
-      if (I.getOperand(1).getFPImm()->getValueAPF().isExactlyValue(0.0))
+      // 0.0 is not covered by tablegen for FP128. So we will handle this 
+      // scenario in the code here.
+      if (DefSize != 128 && 
----------------
Asif wrote:
> arsenm wrote:
> > Why not just fix this?
> I haven't worked with the tablegen before. Please point to the source files so I can look into it and fix it. 
I think the way this is working differs from the DAG entirely. I think the DAG is emitting constant pool loads earlier and not directly selecting them

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94437/new/

https://reviews.llvm.org/D94437