[PATCH] D94529: [TableGen] Enhance !cast<string> to handle bit and bits types
Paul C. Anagnostopoulos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 12 10:02:59 PST 2021
Paul-C-Anagnostopoulos created this revision.
Paul-C-Anagnostopoulos added reviewers: lattner, dblaikie, craig.topper, fpichet.
Herald added a subscriber: hiraditya.
Paul-C-Anagnostopoulos requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This revision enhances the !cast operator so it can cast bit and bits to string. It could already cast int to string.
I added a test for this change.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D94529
Files:
llvm/lib/TableGen/Record.cpp
llvm/test/TableGen/cast-string.td
Index: llvm/test/TableGen/cast-string.td
===================================================================
--- /dev/null
+++ llvm/test/TableGen/cast-string.td
@@ -0,0 +1,59 @@
+// RUN: llvm-tblgen %s | FileCheck %s
+// RUN: not llvm-tblgen -DERROR1 %s 2>&1 | FileCheck --check-prefix=ERROR1 %s
+
+// This file tests !cast<string>(...).
+
+defvar IntList = [0, 1, 2, 3, 4, 5, 6];
+
+// CHECK: def Rec0
+// CHECK: string str3 = "a string here"
+
+def Rec0 {
+ string str = "a string";
+ string str2 = !cast<string>(str);
+ string str3 = !cast<string>(str # " here");
+}
+
+// CHECK: def Rec1
+// CHECK: string str = "42 -108"
+
+def Rec1 {
+ int int1 = 42;
+ int int2 = -108;
+ string str = !cast<string>(int1) # " " # !cast<string>(int2);
+}
+
+// CHECK: def Rec2
+// CHECK: string str = "0, 1"
+
+def Rec2 {
+ bit bit1 = false;
+ bit bit2 = true;
+ string str = !cast<string>(bit1) # ", " # !cast<string>(bit2);
+}
+
+// CHECK: def Rec3
+// CHECK: string str = "5 and 37"
+
+def Rec3 {
+ bits<4> bits1 = 0b0101;
+ bits<8> bits2 = 0b00100101;
+ string str = !cast<string>(bits1) # " and " # !cast<string>(bits2);
+}
+
+// CHECK: def Rec4
+// CHECK: string str = "Rec1, Rec2"
+
+def Rec4 {
+ string str = !cast<string>(Rec1) # ", " # !cast<string>(Rec2);
+}
+
+#ifdef ERROR1
+
+// ERROR1: nitializer of 'str' in 'Rec5' could not be fully resolved
+
+def Rec5 {
+ string str = !cast<string>(IntList);
+}
+
+#endif
Index: llvm/lib/TableGen/Record.cpp
===================================================================
--- llvm/lib/TableGen/Record.cpp
+++ llvm/lib/TableGen/Record.cpp
@@ -689,8 +689,10 @@
if (DefInit *LHSd = dyn_cast<DefInit>(LHS))
return StringInit::get(LHSd->getAsString());
- if (IntInit *LHSi = dyn_cast<IntInit>(LHS))
+ if (IntInit *LHSi =
+ dyn_cast_or_null<IntInit>(LHS->convertInitializerTo(IntRecTy::get())))
return StringInit::get(LHSi->getAsString());
+
} else if (isa<RecordRecTy>(getType())) {
if (StringInit *Name = dyn_cast<StringInit>(LHS)) {
if (!CurRec && !IsFinal)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94529.316149.patch
Type: text/x-patch
Size: 2095 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210112/97f8875e/attachment.bin>
More information about the llvm-commits
mailing list