[PATCH] D94487: [LTO] Use lto::backend for code generation (WIP).

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.

I think this is good to be a first step. The approach is correct and left some small suggestion above. The linter warnings need to be fixed as well.

Thanks for working on this.



================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:134
-// passes are initialized.
-void LTOCodeGenerator::initializeLTOPasses() {
-  PassRegistry &R = *PassRegistry::getPassRegistry();
----------------
You need to remove the function declaration in `include/llvm/LTO/legacy/LTOCodeGenerator.h`


================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:604
 
   legacy::PassManager preCodeGenPasses;
 
----------------
I will try to remove all legacy pass manager from LTOCodegenerator in one commit to avoid complication. You can do ThinLTOCodeGenerator in a separate commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94487/new/

https://reviews.llvm.org/D94487