[PATCH] D94475: [MC] Emit ELF files with ELFOSABI_GNU if specified in triple

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 09:51:56 PST 2021


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

This is known. GNU as by default emits `ELFOSABI_NONE` on Linux - if it does not use any GNU extensioin. If the assembly uses STT_GNU_IFUNC/STB_GNU_UNIQUE, GNU as will switch to `ELFOSABI_GNU`.

The patch improves the few cases but regresses other cases, so I am requesting changes. It is also unclear whether respecting the GNU behavior is strictly necessary. STT_GNU_IFUNC is GNU extension and it is adopted by some other OSes. I am not sure the `readelf -S` output is a justifying reason for this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94475/new/

https://reviews.llvm.org/D94475



More information about the llvm-commits mailing list