[PATCH] D94347: [WebAssembly] locals can now be indirect in DWARF

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added a comment.

This solution is certainly driven by what fits well in the current way LLVM does things, though all the different steps of lowering.

I can "slip in" a `DW_OP_deref`, but then the bool that indicates that this needs to happen needs to be passed through all the way from ExplicitLocals to the DWARF emitter, for which the likeliest storage is the TargetIndex like we are doing currently. So at least code-wise this solution would be less elegant, since now we're duplicating information at the end.

I am sure there are other structures possible, but I would suggest that is potential future improvement.

> I think it is, at least with today's ABIs.

Do these ABIs need to be adhered to for static functions calling each other internally to a compilation unit (in -O2)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94347/new/

https://reviews.llvm.org/D94347