[PATCH] D94377: [StringExtras] Add a helper class for comma-separated lists

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 08:59:46 PST 2021


kazu added a comment.

In D94377#2493048 <https://reviews.llvm.org/D94377#2493048>, @dblaikie wrote:

> In D94377#2491956 <https://reviews.llvm.org/D94377#2491956>, @MaskRay wrote:
>
>> The name `SubsequentDelim` looks a bit strange to me. Maybe others have suggestions on the name?
>> (personally I might choose `AddDelimUnlessFirst`)
>
> Yeah, I don't have any particularly compelling names - maybe "StreamableSeparator"

How about `ListSeparator`?  Windows seems to have regional setting called "List Separator" specifying what separator to use in a list, so I am not inventing a new term at least:

https://support.talkdesk.com/hc/en-us/articles/360047099811-CSV-Files-and-Regional-Settings

I'd like to keep the name reasonably short, so I might sweep under the carpet the fact that the first invocation generates the empty string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94377/new/

https://reviews.llvm.org/D94377



More information about the llvm-commits mailing list