[PATCH] D94502: [FunctionAttrs] Derive willreturn for fns with readonly` & `mustprogress`.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1436
+    F->addFnAttr(Attribute::WillReturn);
+    F->removeFnAttr(Attribute::NoReturn);
+  }
----------------
jdoerfert wrote:
> `Changed = true;` ;)
> Changed = true; ;)
 
yeah.



I guess a comment here might be helpful as well. It is possible that the function has been marked as `noreturn` earlier, e.g. because it does not have any returns. In such cases, `will return` seems a better choice, if possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94502/new/

https://reviews.llvm.org/D94502