[PATCH] D94460: [dsymutil] Copy eh_frame content into the dSYM companion file.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: llvm/test/tools/dsymutil/X86/eh_frame.test:25
+CHECK: 14 00 00 00 00 00 00 00 01 7a 52 00 01 78 10 01
+CHECK: 10 0c 07 08 90 01 00 00
----------------
jasonmolenda wrote:
> jasonmolenda wrote:
> > These eh_frame bytes are architecture-specific (and likely codegen-specific if the compiler ever changes how many bytes are emitted).  Is it possible to use dwarfdump on the .dSYM binary and search for the function name in the eh_frame dump, and assume that the instructions that it has are correct? 
> Or confirm that the eh_frame bytes from the executable are the same as the dSYM's.
The dsymutil tests use checked-in binaries so the test is resilient in that regard. The RUN line on 21 checks the input binary as a sanity check (in case someone decides to regenerate the binary). 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94460/new/

https://reviews.llvm.org/D94460